search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

Changed character limit for business's legal name #601

Closed Madhavkapoor28 closed 1 year ago

Madhavkapoor28 commented 1 year ago

Issue #: /bcgov/entity#14923

Description of changes:

Changed the max character limit for a business's legal name in home jurisdiction.

seeker25 commented 1 year ago

Please update package.json to "version": "4.1.9", or higher (current as of June 23rd, 2023), npm i should update package-lock.json automatically. If you notice too many lines changed in package-lock.json might want to check your nodeJs version and make sure it matches the github CI pipeline here: https://github.com/bcgov/namerequest/blob/1eb90efe13ab0f35e6c26552ece0dd68cc63b641/.github/workflows/ci.yml#L28

If it doesn't match - nvm is fairly useful for our repos, although most of the repos are on version 16 ish.

pwei1018 commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-601-by5r1j28.web.app

severinbeauvais commented 1 year ago

@seeker25 What's the status of this PR? Should someone else take it over and get it reviewed + merged?

seeker25 commented 1 year ago

Haha not too sure, @pwei1018 over to you

pwei1018 commented 1 year ago

@severinbeauvais Can you put this change in your pull request and close this one? This one seems hard to solve the conflicts of package-lock.json.

severinbeauvais commented 1 year ago

@severinbeauvais Can you put this change in your pull request and close this one? This one seems hard to solve the conflicts of package-lock.json.

Yes, OK. I will close this PR and create a new one (under my GH id).