Closed severinbeauvais closed 1 year ago
Eve, Omid -- FYI only.
This is for story 16519.
Hopefully there won't be too many (or any) fixes to main branch while we develop on release-5.0.0 branch (which we will merge when it's safe to do so without breaking anything).
Only the app version updated. Looks good to me.
For now, yes. Should I merge this and then create more PRs for the rest of the work in this ticket, or can I add extra work to THIS PR? (In case you don't want to see the extra work -- do you?)
I agree that it is better to build a base first.
This repo had unit test errors before the present changes.
Using Node 12, before changes:
~Using Node 16, after changes:~ (originally screenshot deleted)
Update - I fixed the unit tests and some build issues:
Your package-lock has changed quite a bit - I'd recommend a decent retest.
Your package-lock has changed quite a bit - I'd recommend a decent retest.
For sure. We will be making a lot of changes to this feature branch so it will undergo lots of testing.
Issue #: /bcgov/entity#16634
The "way of navigating" story (16519) contains many tickets that cannot be merged to main branch without breaking things. Hence, THIS pull request implements some base changes, including a new feature branch, for those changes. When the feature branch is working correctly, then it will be merged into main branch.
Description of changes: Commit 1:
Commit 2:
Commit 3:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).