search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

16633 Add breadcrumb + update title/subtitle + change tab title widths #618

Closed leodube-aot closed 1 year ago

leodube-aot commented 1 year ago

Issue #: /bcgov/entity#16633

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 1 year ago

Please rebase to new branch https://github.com/bcgov/namerequest/tree/feature-way-of-navigating so that you are left with only your commits in this PR.

(Sorry about the branch change -- needed for consistent branch rules in Github and Google Cloud Build.)

pwei1018 commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-618-hb3335le.web.app

severinbeauvais commented 1 year ago

Check with the UX team (Janis or Yui) whether the active tab should always be wider -- I see the Request tab is now wider, but the Manage tab is still narrow when active.

severinbeauvais commented 1 year ago

You still have conflicting files. This is because another PR was merged between the time you checked out the code and this PR. You need to rebase to the latest commits in the branch, and then probably update the app version again. Ask if you need help with this.

severinbeauvais commented 1 year ago

FYI, I restarted the testing-coverage check since it had failed due to external environmental issues. It worked the second time.

leodube-aot commented 1 year ago

@severinbeauvais I believe this should be ready for merge

leodube-aot commented 1 year ago

/gcbrun

JazzarKarim commented 1 year ago

/gcbrun

I don't think it'll work Leo since the PR has already been merged.

leodube-aot commented 1 year ago

/gcbrun

I don't think it'll work Leo since the PR has already been merged.

Ah I see thanks for the heads up Karim. I'm trying to provide a link for UX to have a look at the changes. Any ideas the best way to do that?

JazzarKarim commented 1 year ago

/gcbrun

I don't think it'll work Leo since the PR has already been merged.

Ah I see thanks for the heads up Karim. I'm trying to provide a link for UX to have a look at the changes. Any ideas the best way to do that?

Sev created a dummy PR yesterday that has the latest version of Name Request UI (includes your changes). PR: https://github.com/bcgov/namerequest/pull/626. /gcbrun should work there.

You can use the link provided in the PR: https://namerequest-dev--pr-626-o8hprvjv.web.app/ You can also double check that your changes are there. Let me know if you need anything else Leo!

leodube-aot commented 1 year ago

@JazzarKarim Thanks for the help 🙌