Fixed in response to Yui's comment

bcgov / namerequest

Public Front End for the Name Request System

1 stars 42 forks source link

Fixed in response to Yui's comment #628

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#16635

Description of changes:

This fixes the comment Yui mentioned regarding the registration/incorporation flow. Yui's comment: https://github.com/bcgov/entity/issues/16635#issuecomment-1642807197
The behavior is exactly like in PROD now (which is what we want according to Yui).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-628-mefl84wf.web.app

JazzarKarim commented 1 year ago

Is that how it's done elsewhere?

See line 62. Thoughts?

This is not how it's done currently in main branch. I tried to match between the two but there's too much code to dig in (plus a lot of stuff is now different due to the changes you and I have made). So, I had to improvise and come up with my own solution 😎

Also, regarding line 62, that's how I originally was trying to do it. It wasn't working though (when society is selected, entity_type_cd was not being changed in the function).

severinbeauvais commented 1 year ago

Oh well, it's fine then.