search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

17153-Add CP entity type case #636

Closed ketaki-deodhar closed 1 year ago

ketaki-deodhar commented 1 year ago

Issue #: /bcgov/entity#17153

Description of changes:

Issue; Riyaz could not incorporate a CP from a NR. Received error when Incorporate Now clicked

Solution: Add CP entity type case

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 1 year ago

Don't forget to assign yourself and update package version please Ketaki 🙌

ketaki-deodhar commented 1 year ago

Don't forget to assign yourself and update package version please Ketaki 🙌

Won't but thanks for the reminder. I usually update it after reviews are done and ready to go :)

ketaki-deodhar commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-636-tyxph75s.web.app

ChrisGabel23 commented 1 year ago

Would it be beneficial to pre-emptively add any other entity types not already on the list?