search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

16918 add BusinessLookupComponent #638

Closed kzdev420 closed 1 year ago

kzdev420 commented 1 year ago

Issue #: /bcgov/entity#16918

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 1 year ago

I don't see the following:

Do you have screenshots to show?

severinbeauvais commented 1 year ago

Looks good. Can you show a couple of screenshots, please?

Also a note to devs who want to test this: there is a special key (which we won't post in GH) for accessing the business search API without a JWT (auth token). This is so we can search for a business before the user logs in. This will be sorted out in a different ticket.

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-638-62lfcpe2.web.app

JazzarKarim commented 1 year ago

Also a note to devs who want to test this: there is a special key (which we won't post in GH) for accessing the business search API without a JWT (auth token). This is so we can search for a business before the user logs in. This will be sorted out in a different ticket.

I'm trying to use it in the temporary URL however I'm seeing an error with the Content Security Policy. dev error kevin

I've encountered that when I implemented Maximus' Webchat. It would run on my local but not in DEV. I had to add to the CSP an additional link. Could this also be the case here?

severinbeauvais commented 1 year ago

I've encountered that when I implemented Maximus' Webchat. It would run on my local but not in DEV. I had to add to the CSP an additional link. Could this also be the case here?

~Yeah, maybe. Try it and report back if it doesn't work.~

Check if the "cloudbuild-pr-yaml" file contains the business search API key. If not, add it. (Only the keys not already in env file need to be added to this script.)