bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

16637 Don't show numbered flow for CP + variable Incorporate Now button label #639

Closed ketaki-deodhar closed 1 year ago

ketaki-deodhar commented 1 year ago

Issue #: /bcgov/entity#16637

Description of changes:

Temp url: https://namerequest-dev--pr-639-c9rqzr4l.web.app/

Some screenshots showing the Continuation In flow:

COOP:

image

image

Limited company Named:

image

image

Approved NR Limited company Named:

image

Limited company Numbered: Will always show link to Colin as Continuation In applications are not yet implemented

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

ketaki-deodhar commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-639-c9rqzr4l.web.app

severinbeauvais commented 1 year ago

When the NR is approved, what does the Existing NR page look like for your Continuation In examples above?

ketaki-deodhar commented 1 year ago

@severinbeauvais this is how approved NR looks. It does not show 'Incorporate Now' button.

Approved NR Limited company Named:

image

supported entity check: image image

severinbeauvais commented 1 year ago

Thanks for the approved Continuation In NR. Should it should a link to COLIN?

ketaki-deodhar commented 1 year ago

Thanks for the approved Continuation In NR. Should it should a link to COLIN?

I looked in the code and there aren't any instances we show COLIN link in this component but definitely can be added. Should I check with Yui/Janis?

severinbeauvais commented 1 year ago

Thanks for the approved Continuation In NR. Should it should a link to COLIN?

I looked in the code and there aren't any instances we show COLIN link in this component but definitely can be added. Should I check with Yui/Janis?

We just decided this morning: no button to COLIN. (Same thing we have now.)

I will add related comments to the ticket regarding this

ketaki-deodhar commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-639-c9rqzr4l.web.app

ketaki-deodhar commented 1 year ago

LGTM but please get another review or 2 before merging. (You could ask Travis to add their new dev to this PR.)

as a reviewer?

severinbeauvais commented 1 year ago

LGTM but please get another review or 2 before merging. (You could ask Travis to add their new dev to this PR.)

as a reviewer?

Yes, but I'm mixed up. This is Namerequest. That other dev is working in Auth Web.

I'll ask Eve. She likes Namerequest I think 😄

ketaki-deodhar commented 1 year ago

~@seeker25 can you please add your new dev to this PR?~

@seeker25 Disregard ^^

seeker25 commented 1 year ago

LGTM