search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

Populate business lookup search API Key #648

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#16918

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-648-3ldflrwz.web.app

JazzarKarim commented 1 year ago

@severinbeauvais @kzdev420 I've asked Patrick to add the key to the GCB. I've also added it to the cloudbuild-pr.yaml file.

The key is being populated: key being populated

~However, It's still not working for some reason.~ It's working now 🥳 This PR has to be merged.

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-648-3ldflrwz.web.app

JazzarKarim commented 1 year ago

Ah, so this is a 3-fer:

  1. add missing CSP domain
  2. add missing key assignment from GCP
  3. create temp URL

Looks great! Thanks for doing this!

Also, thanks to @pwei1018 for his quick assistance in adding the missing key 🙌

The demo on Tuesday helped a lot 👍