search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

17206 implement society NR flows #651

Closed eve-git closed 1 year ago

eve-git commented 1 year ago

Issue #: /bcgov/entity#17206

Description of changes: implement society NR flows.

new environment variable: VUE_APP_SOCIETIES_ONLINE_HOME_URL="https://dev.bcregistry.ca/societies/" new feature flag: enable-society

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-651-dk4f535f.web.app

eve-git commented 1 year ago

@severinbeauvais I've unit tested. @pwei1018 provided a temporary url for review. Does it mean the code merge will be applied after it has been tested?

JazzarKarim commented 1 year ago

@severinbeauvais I've unit tested. @pwei1018 provided a temporary url for review. Does it mean the code merge will be applied after it has been tested?

Eve, the temporary URL is automatically generated after anyone commenting /gcbru (I didn't put an n in the end because it'll run the cloud build and generate another link). The reason we do that so that other developers can check/test the work and in this case, it's a feature branch. The link will be used in UX Assurance and in QA since the changes won't be in DEV after merging.

eve-git commented 1 year ago

@JazzarKarim please commit /gcbrun again because I have a new commit. Thanks. So, can I merge the code?

pwei1018 commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-651-dk4f535f.web.app

JazzarKarim commented 1 year ago

@JazzarKarim please commit /xxxxx again because I have a new commit. Thanks. So, can I merge the code?

Sorry Eve, I just saw this. Sure thing! Btw, you can also run the command yourself like just what happened 👍

severinbeauvais commented 1 year ago

@severinbeauvais I've unit tested. ... Does it mean the code merge will be applied after it has been tested?

Karim may have answered this... The PR temporary URL allows preliminary testing before the PR is merged. If you're asking about the feature branch -- we will need a PR to merge the feature branch into main, once everything is complete.

Ask again if you still have questions.