bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

17489 Incremental business fetch + bit of cleanup #663

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#17489

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 1 year ago

~I'm still working on validation of the entered business id (in business-fetch.vue) but otherwise this is usable right now.~ done

I will also have a future PR (in a few days) to use the new endpoint to fetch COLIN data. I can fix any UXA issues then (since I still haven't seen a design for this).

Note that a business that only exists in COLIN currently returns partially-mocked data (hard-coded legal name, type and state). For your testing, you can just use that data as-is or pick a business that exists in LEAR.

severinbeauvais commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-663-tjsvuma7.web.app