Closed chenhongjing closed 1 year ago
Hongjing, I merged my PR. Some of my changes might overlap with yours.
Please reach out if you need help with rebasing.
I just verified, all my changes are working perfectly after rebasing. I know this must've been not fun at all. Thanks Hongjing! 🙌
~Shouldn't this prompt me for designations?~ fixed!
~I created an alteration NR on the temp URL and got this. The NR type (BEN) is incorrect. It should be BC (which is a BEN in Namerequest).~ fixed!
/gcbrun
Temporary Url for review: https://namerequest-dev--pr-667-z8piuhtc.web.app
@severinbeauvais The corp number should also be populated with the business identifier here as with restoration workflow right?
@severinbeauvais The corp number should also be populated with the business identifier here as with restoration workflow right?
Exactly. Alteration, restoration, name change.
Exactly. Alteration, restoration, name change.
Alright. Hongjing, don't worry about that for now (so that you can move this ticket through). I'll fix that in both our flows. I'll create a new ticket for it (I tried fixing that in my ticket but I think it needs a little bit of a dive). Is that OK with you Sev? @severinbeauvais
/gcbrun
Temporary Url for review: https://namerequest-dev--pr-667-z8piuhtc.web.app
Ready to merge?! 👀
Issue #: bcgov/entity#16641
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).