search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

Merge Way of Navigating Feature Branch with main #679

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#17642

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-679-fy6f29hk.web.app

JazzarKarim commented 1 year ago

Wow, I'm so proud of you guys! This team made so many great changes in this project. The code looks so much better than before.

None of my comments should hold back this merge. They're just things we need to ask about or look into... for future changes.

This wouldn't have been possible without your guidance with everything Sev ❤️

JazzarKarim commented 1 year ago

@severinbeauvais OK to merge now? Shall I press on the button? 😁

severinbeauvais commented 1 year ago

@severinbeauvais OK to merge now? Shall I press on the button? 😁

Do it :)

JazzarKarim commented 1 year ago

@severinbeauvais Are we squashing and merging to compress all the commits in one or Rebasing and merging? If I have to take a guess it's the latter but I'm just making sure.

severinbeauvais commented 1 year ago

I'd say don't squash, so that we can see all commits separately.