bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

17727 Refactored start a new BC based business #685

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#17727

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 1 year ago

/gcbrun

JazzarKarim commented 1 year ago

I've tested every single possible business type and compared it to DEV. It looks exactly similar now.

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-685-avcajisb.web.app

JazzarKarim commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-685-avcajisb.web.app

ketaki-deodhar commented 1 year ago

I think UI is not matching DEV.

In DEV: image

Temp URL: image

JazzarKarim commented 1 year ago

I think UI is not matching DEV.

Thanks for catching this Ketaki. On it.

JazzarKarim commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-685-avcajisb.web.app

leodube-aot commented 1 year ago

I think it's missing the Check This Name button, at least for BENs.

Screenshot 2023-09-14 084245

JazzarKarim commented 1 year ago

/gcbrun

JazzarKarim commented 1 year ago

I think it's missing the Check This Name button, at least for BENs.

Thanks for catching that Leo! Hopefully, it should be OK in latest temp URL.

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-685-avcajisb.web.app

JazzarKarim commented 1 year ago

@leodube-aot @ketaki-deodhar OK with you to merge now (I want to start with the restoration flow after rebasing from here)?