search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

17727 Refactored Conversion/Alteration Flow #688

Closed leodube-aot closed 1 year ago

leodube-aot commented 1 year ago

Issue #: /bcgov/entity#17727

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

leodube-aot commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-688-1g710hqa.web.app

severinbeauvais commented 1 year ago

Did you compare exactly with Dev Namerequest?

leodube-aot commented 1 year ago

Looks good. Do you need to support xpro or societies?

I'm not 100% sure. The UXPin doesn't state anything about those being part of allowable alterations but I'll double check.

Edit: On dev I tested with an Expro (A0002744) and it gives an error message stating the business cannot alter it's type, which matches with the refactor. Weirdly, dev will also display the Jurisdiction select field despite the error (which I think is likely incorrect), but that does not happen with the refactored version. Will need to try with a society.

Did you compare exactly with Dev Namerequest?

I compared it using a BEN (BC0870877), a ULC (BC0871323), and a Limited Company (BC0870316) and it matched with dev

severinbeauvais commented 1 year ago

Looks good. Do you need to support xpro or societies?

I'm not 100% sure. The UXPin doesn't state anything about those being part of allowable alterations but I'll double check.

Edit: On dev I tested with an Expro (A0002744) and it gives an error message stating the business cannot alter it's type, which matches with the refactor. Weirdly, dev will also display the Jurisdiction select field despite the error (which I think is likely incorrect), but that does not happen with the refactored version. Will need to try with a society.

Did you compare exactly with Dev Namerequest?

I compared it using a BEN (BC0870877), a ULC (BC0871323), and a Limited Company (BC0870316) and it matched with dev

Actually, I remembered: societies can't alter their type,

I think you're right about that being a bug in Dev,

Looks good to me!