bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

17727 - Update Change name flow #689

Closed ketaki-deodhar closed 1 year ago

ketaki-deodhar commented 1 year ago

Issue #: /bcgov/entity#17727

Description of changes:

Update Change Name flow after refactoring

Temporary Url for review: https://namerequest-dev--pr-689-62ljhzmi.web.app/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

leodube-aot commented 1 year ago

When I enter a business into "Find an existing business", then click the "X" button to clear the field, I still see the "Enter a name to request" text field. Comparison with dev:

Screenshot 2023-09-14 085226

ketaki-deodhar commented 1 year ago

When I enter a business into "Find an existing business", then click the "X" button to clear the field, I still see the "Enter a name to request" text field. Comparison with dev:

Screenshot 2023-09-14 085226

Yes, noticed it and looking into it. Thanks for catching it!

ketaki-deodhar commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-689-62ljhzmi.web.app

ketaki-deodhar commented 1 year ago

When I enter a business into "Find an existing business", then click the "X" button to clear the field, I still see the "Enter a name to request" text field. Comparison with dev:

Screenshot 2023-09-14 085226

@leodube-aot is this resolved with the fixes?

ketaki-deodhar commented 1 year ago

@severinbeauvais good to merge?