search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

17727 - Update continuation In flow #692

Closed ketaki-deodhar closed 1 year ago

ketaki-deodhar commented 1 year ago

Issue #: /bcgov/entity#17727

Description of changes:

Update continuation In flow after refactoring

Temporary Url for review: https://namerequest-dev--pr-692-2uopnr59.web.app/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

ketaki-deodhar commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-692-2uopnr59.web.app

ketaki-deodhar commented 1 year ago

@leodube-aot @JazzarKarim could you please take a look and let me know if okay to merge?

JazzarKarim commented 1 year ago

Sorry Ketaki, missed this. LGTM 👍

leodube-aot commented 1 year ago

Hey Ketaki, sorry for the delay but found a strange bug. When I first load the page, and select Continuation In and then choose "Cooperative Association", I don't see a "Check this name" button like I do in dev. If I then choose a different business type like "Limited Company", then select "Cooperative Association" again I do see the button.

Selecting Cooperative Association after clearing state: bug

Selecting Cooperative Association after choosing a different business type first: bug2

ketaki-deodhar commented 1 year ago

Hey Ketaki, sorry for the delay but found a strange bug. When I first load the page, and select Continuation In and then choose "Cooperative Association", I don't see a "Check this name" button like I do in dev. If I then choose a different business type like "Limited Company", then select "Cooperative Association" again I do see the button.

Selecting Cooperative Association after clearing state: bug

Selecting Cooperative Association after choosing a different business type first: bug2

Looking into it! Will create another PR with the fix