17468 Add special cases for xpro aml + fixed nefarious getter reactivity bug

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#17468

Description of changes:

app version = 5.1.9
added misc comments
deleted debugging code
deleted unneeded interface
added special case for aml to clear location when setting a new entity type
added special case for aml to use "BC" options by default (ie, ignore location in entity type options)
fixed getter infinite loop
added special case for aml to not clear entity type when mutating location
updated Check this Name logic for aml
removed debugging statements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 1 year ago

~I just noticed a small bug: after selecting xpro (other than Federal), the Check this Name button should be displayed. This will be a quick fix.~ fixed!

severinbeauvais commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-693-s98nyzxy.web.app

bcgov / namerequest

17468 Add special cases for xpro aml + fixed nefarious getter reactivity bug #693