search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

17727 Refactored New Expro Business Flow #696

Closed leodube-aot closed 1 year ago

leodube-aot commented 1 year ago

Issue #: /bcgov/entity#17727

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

ketaki-deodhar commented 1 year ago

Hey @leodube-aot, Just observed this one. I am not sure if this will be resolved once you get Sev's work from his PR. Just keeping a note here if needs a fix :)

Dev: image

Temp url: image

leodube-aot commented 1 year ago

Hey @leodube-aot, Just observed this one. I am not sure if this will be resolved once you get Sev's work from his PR. Just keeping a note here if needs a fix :)

It should get fixed from Sev's PR but I'll make sure to double check when I rebase!

ketaki-deodhar commented 1 year ago

Hey @leodube-aot, Just observed this one. I am not sure if this will be resolved once you get Sev's work from his PR. Just keeping a note here if needs a fix :)

It should get fixed from Sev's PR but I'll make sure to double check when I rebase!

Sounds good!

leodube-aot commented 1 year ago

Hey @leodube-aot, Just observed this one. I am not sure if this will be resolved once you get Sev's work from his PR. Just keeping a note here if needs a fix :)

@severinbeauvais This issue Ketaki found is still present, I think it might be related to your recent amalgamation bug fix? Should we merge this PR and create a new one to fix the bug?

severinbeauvais commented 1 year ago

@severinbeauvais This issue Ketaki found is still present, I think it might be related to your recent amalgamation bug fix? Should we merge this PR and create a new one to fix the bug?

❌ ~Yes, so that I can get on with merging f/b -> main.~

I note that the order the component is incorrect, too (after selecting jurisdiction, entity type is inserted before it).

severinbeauvais commented 1 year ago

✔️ Or... I could merge f/b -> Dev first and then you could rebase this PR to main branch ...?

leodube-aot commented 1 year ago

@severinbeauvais Yeah I'll fix the order of the components while you merge f/b, then I'll rebase.

leodube-aot commented 1 year ago

I note that the order the component is incorrect, too (after selecting jurisdiction, entity type is inserted before it).

It appears to be correct in the temp url for this PR

severinbeauvais commented 1 year ago

I note that the order the component is incorrect, too (after selecting jurisdiction, entity type is inserted before it).

It appears to be correct in the temp url for this PR

Yes, looks OK now.

Now that large list of entities needs to be fixed. It may have been broken by xpro aml but I'm not sure.

leodube-aot commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-696-k5dya15z.web.app