bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

17903 Upgrade to Vue-CLI v5 + upgrade ESLint, etc + updates for Node 20 #710

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#17903

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 1 year ago

~@pwei1018 Can you help me find why npm run build is failing, please?~ never mind; see comment below

severinbeauvais commented 1 year ago

@pwei1018 Can you help me find why npm run build is failing, please?

I will try upgrading to Vue-CLI v5. If that doesn't work then maybe we should consider changing to Vite. Thoughts?

Update: The build errors referred to "Webpack", which is why I upgraded to Vue-CLI v5 + latest Webpack. Builds fine now.

severinbeauvais commented 1 year ago

~Update: so this builds cleanly and the unit tests are happy (the few we have), but I'm experiencing this error while testing:~

image

This is now fixed.

severinbeauvais commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-710-uutlgp48.web.app