For PR - #17932 Namerequest UI: Drop down menu does not work with keyboard input

bcgov / namerequest

Public Front End for the Name Request System

1 stars 42 forks source link

For PR - #17932 Namerequest UI: Drop down menu does not work with keyboard input #722

Closed jamespaologarcia closed 11 months ago

jamespaologarcia commented 11 months ago

Issue #: /bcgov/entity#17932

Description of changes: Changed to v-list-item and updated v-list-item properties to align the elements.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 11 months ago

/gcbrun

bcregistry-sre commented 11 months ago

Temporary Url for review: https://namerequest-dev--pr-722-thpga0ef.web.app

severinbeauvais commented 11 months ago

James, you merged it a little too quickly :)

There is no technical impact to not updating the app version (in package.json), but it's handy to see the version of a deployed app, ie:

Without this, it's harder to tell if your fix is present in the UI.

This doesn't need to be fixed IMHO.