18159 Fixed name input error message for non-xpro

bcgov / namerequest

Public Front End for the Name Request System

1 stars 44 forks source link

18159 Fixed name input error message for non-xpro #729

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#18159

Description of changes:

app version = 5.2.10
fixed Name Input error message logic
BUG FIX: added missing corp type / entity type conversions
also fixed some GHA warnings (lint-type errors)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 1 year ago

Test Results

New named company:

New sole proprietorship:

New xpro in MRAS jurisdiction:

New xpro in non-MRAS jurisdiction:

severinbeauvais commented 1 year ago

@ketaki-deodhar Please test a bunch of name change scenarios to verify that they all work. Thanks.

severinbeauvais commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://namerequest-dev--pr-729-2j989mi5.web.app