18202 show both named and numbered option for LTD company

[tshyun24]

Issue #: /bcgov/entity#18202

Description of changes: Using isNumberedCompany to determine whether we have the COLIN option, instead of using isSupportedRestoration previously

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

[chenhongjing]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-735-526soleu.web.app

[severinbeauvais]

~Please rebase and update the package files.~ done

Please provide some sample businesses that:

• are and are not supported by FF
• can be only named and can be named/numbered

[tshyun24]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-735-526soleu.web.app

[tshyun24]

Some sample businesses

• Supported by FF : BC0013141 (FF value: UL), BC0871194 (FF value: BC)
• Not supported by FF: CP1002580 (FF value: CP)
• Can only be named: A0076494 (Xpro business)
• Can be named/numbered: BC0024185

[JazzarKarim]

• Supported by FF : BC0013141 (FF value: UL), BC0871194 (FF value: BC)
• Not supported by FF: CP1002580 (FF value: CP)
• Can only be named: A0076494 (Xpro business)
• Can be named/numbered: BC0024185

Shaoyun, for coops, we don't want the numbered and named radio buttons. In DEV: Unless something has changed, this is the expected behavior for coops. They're like a special case. I was having a look in your temp URL, I can see that we got the radio button options.

Also, for "A0076494", I got stuck:

Please have a look in DEV and see the expected result. There's the "Business's full legal name in home jurisdiction" component missing.

[tshyun24]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-735-526soleu.web.app

[tshyun24]

@JazzarKarim @severinbeauvais push a new comment, hopefully fix all the bugs above

[JazzarKarim]

@JazzarKarim @severinbeauvais push a new comment, hopefully fix all the bugs above

So I've tested different types of companies, looks great! Shaoyun, can you please take a SC from your local when the supported-restoration-entities FF is false and when a ULC for example is selected (just like how we discussed yesterday)?

[tshyun24]

So I've tested different types of companies, looks great! Shaoyun, can you please take a SC from your local when the supported-restoration-entities FF is false and when a ULC for example is selected (just like how we discussed yesterday)?

Yes, I just create a ULC business (BC0871496) and make it historical It looks like that in DEV. I think I should not have the Restore Now option? Cause it doesn't include the FF for ULC And the below is in local, same with DEV

[JazzarKarim]

So I've tested different types of companies, looks great! Shaoyun, can you please take a SC from your local when the supported-restoration-entities FF is false and when a ULC for example is selected (just like how we discussed yesterday)?

Yes, I just create a ULC business (BC0871496) and make it historical

What if the FF value is false? Will it show the same thing but instead of "Restore Now", it's "Go To Corporate Online to Register"?

You can set this line to return false to test that! https://github.com/tshyun24/namerequest/blob/f495ad9e87a33ba472479575c3edab334510b7e8/src/mixins/common-mixin.ts#L209

[tshyun24]

What if the FF value is false? Will it show the same thing but instead of "Restore Now", it's "Go To Corporate Online to Register"?

You can set this line to return false to test that! https://github.com/tshyun24/namerequest/blob/f495ad9e87a33ba472479575c3edab334510b7e8/src/mixins/common-mixin.ts#L209

Show "Go To Corporate Online to Register" when I set FF as false

[tshyun24]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-735-526soleu.web.app

[JazzarKarim]

What if the FF value is false? Will it show the same thing but instead of "Restore Now", it's "Go To Corporate Online to Register"? You can set this line to return false to test that! https://github.com/tshyun24/namerequest/blob/f495ad9e87a33ba472479575c3edab334510b7e8/src/mixins/common-mixin.ts#L209

Show "Go To Corporate Online to Register" when I set FF as false

Looks great! This is basically what we want.

[tshyun24]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-735-526soleu.web.app

[tshyun24]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-735-526soleu.web.app

[tshyun24]

/gcbrun

[tshyun24]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-735-526soleu.web.app