search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

17914 added popup for socieites #741

Closed jamespaologarcia closed 10 months ago

jamespaologarcia commented 11 months ago

Issue #: /bcgov/entity#17914

Added a popup for SO and XSO for name change and restoration

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 11 months ago

deleted obsolete comment

severinbeauvais commented 11 months ago

~Do not merge this until after the release on Tuesday, October 31.~ ok to resume merges into main branch

severinbeauvais commented 10 months ago

I restarted all checks that failed due to environmental issue. They have now passed.

deleted remaining obsolete comment

eve-git commented 10 months ago

Could you please update the version number to 5.3.5, as https://github.com/bcgov/namerequest/pull/742 is currently using 5.3.4 and merged already.

severinbeauvais commented 10 months ago

This flow still doesn't work -- should show other input components after I select this society.

image

severinbeauvais commented 10 months ago

This flow still doesn't work -- should show other input components after I select this society.

Still doesn't work after latest changes.

JazzarKarim commented 10 months ago

This flow still doesn't work -- should show other input components after I select this society.

image

Sev, I've tried this in DEV, it's the same thing: dev society

I wonder, what do we exactly need to show in that case? For XS, we show the usual jurisdiction and full legal name like you mentioned (if FF is true). In the case of a regular society though, we didn't have previous behavior. The UXPin also didn't have any mention for that.

severinbeauvais commented 10 months ago

Sev, I've tried this in DEV, it's the same thing:

I wonder, what do we exactly need to show in that case? For XS, we show the usual jurisdiction and full legal name like you mentioned (if FF is true). In the case of a regular society though, we didn't have previous behavior. The UXPin also didn't have any mention for that.

I've been communicating with James on this. It's partly a FF issue and partly a logic issue. See: https://github.com/bcgov/namerequest/pull/743/commits/4cea5ca5fb9866e744e33cbb3228e154d0cc55a5?diff=split&w=1

severinbeauvais commented 10 months ago

/gcbrun

bcregistry-sre commented 10 months ago

Temporary Url for review: https://namerequest-dev--pr-741-l6xc5zp1.web.app