18532 - AM Button Implementation

[jamespaologarcia]

Issue #: /bcgov/entity#18532 Added implementation for amalgamate now button.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[JazzarKarim]

James, I'm pressing on the amalgamate now button after an NR has been approved, but I don't see anything happening. Shouldn't we be getting an HTTP 400 error for now at least since the BE hasn't been setup yet?

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[JazzarKarim]

James, I'm pressing on the amalgamate now button after an NR has been approved, but I don't see anything happening. Shouldn't we be getting an HTTP 400 error for now at least since the BE hasn't been setup yet?

Fixed, thanks!

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[severinbeauvais]

James, please indicate here (or better, in the ticket), what testing you've done, including:

• entities supported by FF (create draft)
• entities not supported by FF (go to COLIN)
• while not logged in
• while already logged in
• numbered amalgamations (button on search page)
• named amalgamations (button on existing request display page)

Thanks.

[jamespaologarcia]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://namerequest-dev--pr-748-w80ga369.web.app

[severinbeauvais]

James, are you ready to merge this, or do you want to do a bit more testing first?

[severinbeauvais]

James, are you ready to merge this, or do you want to do a bit more testing first?

@jamespaologarcia , I wrote this on Nov 29. What's your answer please?

[jamespaologarcia]

James, are you ready to merge this, or do you want to do a bit more testing first?

@jamespaologarcia , I wrote this on Nov 29. What's your answer please?

Hi,

I sent the PR link to Omid. I'm waiting for confirmation before I merge it.

[severinbeauvais]

James, are you ready to merge this, or do you want to do a bit more testing first?

@jamespaologarcia , I wrote this on Nov 29. What's your answer please?

James replied: "All good from my side. I tested the cases you pointed out to me."