search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

18951 Change amalgamation to amalgamationApplication #750

Closed kzdev420 closed 10 months ago

kzdev420 commented 10 months ago

Issue #: /bcgov/entity#18951

Description of changes:

Amalgamation Object will be like this

filing: {
        header: {
          name: 'amalgamationApplication',   // updated
          accountId: 3040
        },
        business: {
          legalType: 'BC'
        },
        amalgamationApplication: {     // updated
          nameRequest: {
            legalType:  'BC'
          },
          type: 'regular'
        }
      }

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 10 months ago

Kevin, you need to import the latest shared enums. That's why the build-check has failed.

Next time, please run the build locally (and also the unit tests and linting) before assigning reviewers to the PR.

severinbeauvais commented 10 months ago

@eve-git @ozamani9gh We would like to merge this PR as soon as possible. Are you able to review this PR? Can we merge it ourselves?

kzdev420 commented 10 months ago

/gcbrun

bcregistry-sre commented 10 months ago

Temporary Url for review: https://namerequest-dev--pr-750-7lf1pe42.web.app