search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

20521 Fixed restoration flow when FF blocks entity type #756

Closed severinbeauvais closed 5 months ago

severinbeauvais commented 5 months ago

Issue #: bcgov/entity#20521

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 48.43%. Comparing base (af26b03) to head (395a286). Report is 314 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #756 +/- ## =========================================== + Coverage 37.48% 48.43% +10.94% =========================================== Files 129 193 +64 Lines 3607 4396 +789 Branches 667 508 -159 =========================================== + Hits 1352 2129 +777 + Misses 2252 2222 -30 - Partials 3 45 +42 ``` | [Files](https://app.codecov.io/gh/bcgov/namerequest/pull/756?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [src/components/dialogs/confirm-name-request.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fdialogs%2Fconfirm-name-request.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvZGlhbG9ncy9jb25maXJtLW5hbWUtcmVxdWVzdC52dWU=) | `100.00% <100.00%> (ø)` | | | [src/components/dialogs/error.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fdialogs%2Ferror.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvZGlhbG9ncy9lcnJvci52dWU=) | `100.00% <ø> (ø)` | | | [...c/components/dialogs/pick-entity-or-conversion.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fdialogs%2Fpick-entity-or-conversion.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvZGlhbG9ncy9waWNrLWVudGl0eS1vci1jb252ZXJzaW9uLnZ1ZQ==) | `100.00% <ø> (ø)` | | | [...ents/new-request/search-components/entity-type.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fnew-request%2Fsearch-components%2Fentity-type.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvbmV3LXJlcXVlc3Qvc2VhcmNoLWNvbXBvbmVudHMvZW50aXR5LXR5cGUudnVl) | `100.00% <ø> (ø)` | | | [src/components/new-request/search.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fnew-request%2Fsearch.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvbmV3LXJlcXVlc3Qvc2VhcmNoLnZ1ZQ==) | `100.00% <ø> (ø)` | | | [src/components/payment/payment-summary.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fpayment%2Fpayment-summary.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvcGF5bWVudC9wYXltZW50LXN1bW1hcnkudnVl) | `100.00% <100.00%> (ø)` | | | [src/components/payment/refund-summary.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fpayment%2Frefund-summary.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvcGF5bWVudC9yZWZ1bmQtc3VtbWFyeS52dWU=) | `100.00% <ø> (ø)` | | | [src/components/payment/staff-payment.vue](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fcomponents%2Fpayment%2Fstaff-payment.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL2NvbXBvbmVudHMvcGF5bWVudC9zdGFmZi1wYXltZW50LnZ1ZQ==) | `100.00% <100.00%> (ø)` | | | [src/mixins/payment-session-mixin.ts](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Fmixins%2Fpayment-session-mixin.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL21peGlucy9wYXltZW50LXNlc3Npb24tbWl4aW4udHM=) | `5.12% <ø> (ø)` | | | [src/router/router.ts](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree&filepath=src%2Frouter%2Frouter.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-c3JjL3JvdXRlci9yb3V0ZXIudHM=) | `60.00% <ø> (ø)` | | | ... and [4 more](https://app.codecov.io/gh/bcgov/namerequest/pull/756?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | | ... and [107 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/namerequest/pull/756/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
severinbeauvais commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://namerequest-dev--pr-756-shnluqg3.web.app

SB says: