Hide Action button when changing name and Go To Colin Button visible

bcgov / namerequest

Public Front End for the Name Request System

1 stars 44 forks source link

Hide Action button when changing name and Go To Colin Button visible #757

Closed eve-git closed 6 months ago

eve-git commented 6 months ago

Issue #: /bcgov/entity### https://github.com/bcgov/entity/issues/20529

Description of changes: Hide action button when changing name to a numbered name and the legal type is not supported by FF

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

eve-git commented 6 months ago

/gcbrun

bcregistry-sre commented 6 months ago

Temporary Url for review: https://namerequest-dev--pr-757-p8kfadau.web.app

severinbeauvais commented 6 months ago

@eve-git , did you change the FF to test this scenario (as described in the ticket)?

eve-git commented 6 months ago

@eve-git , did you change the FF to test this scenario (as described in the ticket)?

Yes, I changed FF and tested, it worked on both of the two options. I think the coding logic is good too.