search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

19384 PNPM replacement #758

Closed eve-git closed 5 months ago

eve-git commented 5 months ago

Issue #: /bcgov/entity### https://github.com/bcgov/entity/issues/19384

Description of changes: PNPM replacement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

eve-git commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app

eve-git commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app

eve-git commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app

eve-git commented 5 months ago

There are three tasks with errors. @pwei1018 @bolyachevets, is this acceptable? Any suggestions?

bolyachevets commented 5 months ago

There are three tasks with errors. @pwei1018 @bolyachevets, is this acceptable? Any suggestions?

the steps are failing, because it is still using the old workflow currently in namerequest repo (which calls Makefile etc.), the new workflow Patrick is working on is referenced here https://github.com/bcgov/namerequest/pull/758

eve-git commented 5 months ago

!! Please hold on merge till sprint 21.2 released by April 30th noon !!

bolyachevets commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app

seeker25 commented 5 months ago

Thanks for this, book marking for auth-web

eve-git commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://namerequest-dev--pr-758-wz8vlgsi.web.app