21033 Use different entity types for continuation in NRs

severinbeauvais commented 6 months ago

Issue #: bcgov/entity#21033

Description of changes:

app version = 5.4.9
added missing entity type (CS) to enum
added cont in entity type data
added cont in types to list of BC types
updated MVE request action mapping for cont in
updated getters to return alternate entity type data for cont in vs BC
added CS to society code checks
added cont in codes to numbered entity types list

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 6 months ago

@eve-git , is that code-coverage error a remnant of the pnpm change you recently did?

severinbeauvais commented 6 months ago

/gcbrun

JazzarKarim commented 6 months ago

Last commit LGTM Sev 👍

bcregistry-sre commented 6 months ago

Temporary Url for review: https://namerequest-dev--pr-763-m2wjrmib.web.app

severinbeauvais commented 6 months ago

Folks, sorry, but this solution got messy -- it was sending the continuation in codes (eg, "C") instead of the regular codes (eg, "CR") to NameX API, which was crashing (HTTP 500).

So I went with the alternate solution, which turns out to be much simpler. It will be in another PR.

Update: The new PR is https://github.com/bcgov/namerequest/pull/764.

bcgov / namerequest

21033 Use different entity types for continuation in NRs #763