dmitri-korin-bcps
commented
6 months ago @afwilcox
Action Codes will need to have Short and Long descriptions returned in order for drop downs to function.
+ I modified the Action Codes query to return both short and long descriptions.I'm not sure what the action_type_code on the CreateCaseFileInput mutation is for. Is it required?
+ Action Type input parameter is to distinguish complaint assessment actions + from other possible actions that we may introduce in future. It is not required. + If not passed it default to “COMPASSESS”CreateCaseFile Mutations requires an input of AssessmentDetails, however there is no guarantee what order the sections are going to be entered in so this field should be optional if we are going to continue with this route, however I actually don't think you want assessment_actions here at all in the mutation. The original design for both the queries and the mutation called for more specific queries and mutations. This was based on the best practice to make mutations as specific as possible. Right now the CreateCaseFile mutation is responsible for creating both the case and the Assessment, as we continue to add sections this is going to grow and it will eventually be quite unmaintainable. I recommend that you remove the AssessmentDetails from CreatCaseFile Mutation and expose CreateAssessmentDetails as a top level mutation that will also create a case if it doesn't exist.
+ The Case and AssessmentDetails objects are currently at the same level in the database. + I can modify the app to merge Case and AssessmentDetails objects at the GraphQL level. + We may leave mutation name CreateCase or change it to CreateAssessment. + However, since there is no such object as Assessment at the data layer, + I think it is more logical to name mutations CreateCase. + The assessment details are just a subset of the case’s fields. + Let me know what you think.CreateAssessmentDetailsInput has assessment_actions as mandatory but I don't think this is correct because if action_not_requied_ind = 'N' there might not be any assessment actions provided (TBD on some requirements here maybe?)
+ CreateAssessmentDetailsInput has assessment_actions parameter which has an array type and is mandatory. + If assessment does not require any actions, we pass an empty array in "assessment_actions" + and the app will not associate any actions with the case then. + I have just successfully tested it in GraphQL Playground.I was unable to call the CreateCaseFile Mutation - this is because it looks there is something odd in the prisma generation where both a case_guid and a case_file are required. Only the case_guid was provided.
+ CreateCaseFile mutation does not require any id as an input parameter. It automatically generates a case id. + See the screenshot. + Please use the GraphQL queries that I included in the PR comment for testing.
😄
afwilcox
marqueone-ps
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Case Management changes for CE-356.
_Both queries and mutations require authentication and membership in COSOFFICER role
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
GraphQL queries for testing
View GraphQL queries
### Create Assessment ```json mutation CreateAssessment($createAssessmentInput: CreateAssessmentInput!) { createAssessment(createAssessmentInput: $createAssessmentInput) { caseIdentifier leadIdentifier assessmentDetails { actionNotRequired actionJustificationCode actionJustificationShortDescription actionJustificationLongDescription actionJustificationActiveIndicator actions { actor date actionCode shortDescription longDescription activeIndicator } } } } { "createAssessmentInput": { "leadIdentifier": "24-000021", "createUserId": "officerbob", "assessmentDetails": { "actionNotRequired": false, "actionJustificationCode": "OTHOPRPRTY", "actions": [{ "actor": "61d6d74f-0442-4479-ae4d-ff814a4de15d", "date": "3/1/2019", "actionCode": "ASSESSHIST", "activeIndicator": true }, { "actor": "a126bd2b-fc99-4fd0-a8cc-29ef4f595c97", "date": 1708578077, "actionCode": "ASSESSRISK", "activeIndicator": true }, { "actor": "a126bd2b-fc99-4fd0-a8cc-29ef4f595c97", "date": 1708578078, "actionCode": "CNFRMIDENT", "activeIndicator": true }, { "actor": "a126bd2b-fc99-4fd0-a8cc-29ef4f595c97", "date": 1708578079, "actionCode": "ASSESSHLTH", "activeIndicator": true } ] }, "agencyCode": "COS", "caseCode": "HWCR" } } ``` ### Update Assessment ```json mutation UpdateAssessment($updateAssessmentInput: UpdateAssessmentInput!) { updateAssessment(updateAssessmentInput: $updateAssessmentInput) { caseIdentifier leadIdentifier assessmentDetails { actionNotRequired actionJustificationCode actionJustificationShortDescription actionJustificationLongDescription actionJustificationActiveIndicator actions { actor date actionCode shortDescription longDescription activeIndicator } } } } { "updateAssessmentInput": { "leadIdentifier": "24-000020", "caseIdentifier": "06cd489e-aa99-481f-b4dd-8506b0e4e64a", "updateUserId": "officerjohn", "assessmentDetails": { "actionNotRequired": true, "actionJustificationCode": "OTHOPRPRTY", "actions": [{ "actor": "61d6d74f-0442-4479-ae4d-ff814a4de15d", "date": "3/1/2019", "actionCode": "ASSESSHIST", "activeIndicator": false }, { "actor": "a126bd2b-fc99-4fd0-a8cc-29ef4f595c97", "date": 1708578077, "actionCode": "ASSESSRISK", "activeIndicator": true }, { "actor": "a126bd2b-fc99-4fd0-a8cc-29ef4f595c97", "date": 1708578078, "actionCode": "CNFRMIDENT", "activeIndicator": true }, { "actor": "a126bd2b-fc99-4fd0-a8cc-29ef4f595c97", "date": 1708578079, "actionCode": "ASSESSHLTH", "activeIndicator": true }] }, "agencyCode": "COS", "caseCode": "HWCR" } } ``` ### Get Case and Assessment ```json query { getCaseFile (caseIdentifier: "669f9bd7-e24f-4853-8158-9222a964d5f6") { caseIdentifier leadIdentifier assessmentDetails { actionNotRequired actionJustificationCode actionJustificationShortDescription actionJustificationLongDescription actionJustificationActiveIndicator actions { actor date actionCode shortDescription longDescription activeIndicator } } } } ``` ### Get Case and Assessment by Lead Id ```json query { getCaseFileByLeadId (leadIdentifier: "24-000016") { caseIdentifier leadIdentifier assessmentDetails { actionNotRequired actionJustificationCode actionJustificationShortDescription actionJustificationLongDescription actionJustificationActiveIndicator actions { actor date actionCode shortDescription longDescription activeIndicator } } } } ``` ### Get Inaction Justification Types ```json query { inactionJustificationTypes (agencyCode: "COS") { actionJustificationCode agencyCode shortDescription longDescription displayOrder activeIndicator } } ``` ### Get HWCR Assessment Actions ```json query { HWCRAssessmentActions (actionTypeCode: "COMPASSESS") { actionTypeCode actionCode displayOrder activeIndicator shortDescription longDescription } } ```
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: