Create a reusable type for Action (consider renaming it something different so it doesn’t collide with Prisma) and update all the other types (e.g. Assessment) to use it
Add actionId to the type to allow for easy CRUD on a specific record
Split case_file.graphql into multiple .graphql files for better organization
Type of change
Please delete options that are not relevant.
[x] Refactor
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
@cnesmithsalus @marqueone-ps - Somewhat related to this comment I'm actually a bit confused by what's going on here.
When I look at the Case_File_types.GQL it looks good, there is only one type of action there: CaseFileAction
However I'm a bit confused as to why the hwcr_*_action.gql continue to define the distinct types?
I think what this means is that the checkbox display are driven via one type, but the actual saving of the data is driven by another type
I'm concerned there is an unfortunate naming collision going on... I can't tell if Case_File_Actions refers to all types of actions that can appear on a case file (looking at case_file_types.gql I think this is the case...) or if it's only meant to represent the specific Case_File_Actions (e.g. Notes, and Reviews)
I think the shortest way to remediate this would be to:
Remove the GQL Queries from case_file_action.gql as suggested
Update the hwcr_*_action.gql files to refer to the CaseFileAction Type instead of a custom type
Given that CaseFileAction is a superset of the fields, this shouldn't be an issue.
Description
Create a reusable type for Action (consider renaming it something different so it doesn’t collide with Prisma) and update all the other types (e.g. Assessment) to use it
Add actionId to the type to allow for easy CRUD on a specific record
Split case_file.graphql into multiple .graphql files for better organization
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: