search

bcgov / nr-fom

Forestry Operations Map
Apache License 2.0
0 stars 1 forks source link

fix: missing prod label for cronjob (among others?) #564

Closed DerekRoberts closed 5 months ago

DerekRoberts commented 5 months ago

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.

MCatherine1994 commented 5 months ago
Screen Shot 2024-01-17 at 9 44 44 AM

Hi Derek, just wondering are we still going to use "test" tag image in prod deployment? if we already promote image with tag "prod" in the previous step, maybe we can use the prod tag?

DerekRoberts commented 5 months ago

@MCatherine1994 No! That was a mistake. Thanks for the catch. :)

MCatherine1994 commented 5 months ago

Hi Derek, just wondering in the openshift deployment yaml for the api, the cron job image is using image: ${REGISTRY}/${PROMOTE}, and the deployment config image is using image: ${NAME}-${ZONE}-${COMPONENT}:${ZONE}-api from image stream, I wonder shall we make them the same? or you'll have another pr for that?

DerekRoberts commented 5 months ago

@MCatherine1994 That's doable! I'd prefer to merge this and put the variable and image registry changes in another PR, since they're more of an improvement and less of a break/fix.

DerekRoberts commented 5 months ago

Rolled into https://github.com/bcgov/nr-fom/pull/568. Closing.