bcgov / nr-forest-client-api

Forest client API allows systems to consume forest client data without having to connect to a database
Apache License 2.0
6 stars 1 forks source link

feat(FSADT1-1096): adding count header #198

Closed paulushcgcj closed 8 months ago

paulushcgcj commented 8 months ago

Description

Added a header called X-Total-Count to all list/flux endpoints to provide the total amount of results that this request can provide.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below. API available

Once merged, code will be promoted and handed off to following workflow run. Main Merge Workflow

github-actions[bot] commented 8 months ago

Current changelog

Features

github-actions[bot] commented 8 months ago
Overall Project 99.38% :green_apple:
Files changed 100% :green_apple:


File Coverage
ClientService.java 100% :green_apple:
ClientController.java 100% :green_apple:
ClientMapper.java 100% :green_apple:
github-actions[bot] commented 8 months ago
Overall Project 99.38% :green_apple:
Files changed 100% :green_apple:


File Coverage
ClientService.java 100% :green_apple:
ClientController.java 100% :green_apple:
ClientMapper.java 100% :green_apple:
github-actions[bot] commented 8 months ago
Overall Project 99.38% :green_apple:
Files changed 100% :green_apple:


File Coverage
ClientService.java 100% :green_apple:
ClientController.java 100% :green_apple:
ClientMapper.java 100% :green_apple:
RMCampos commented 8 months ago

Thank you @paulushcgcj that looks great! 💯

I'm waiting for feedbacks from the rest of the team now :)

github-actions[bot] commented 8 months ago

Your Pull Request code is being promoted! Please follow the link below. Main Merge Workflow