bcgov / nr-forests-access-management

Authorization solution for BC natural resource sector
Apache License 2.0
8 stars 2 forks source link

fix: #1402 improve the loading behaviour for the frontend tables #1450

Closed NickSaglioni closed 2 weeks ago

NickSaglioni commented 3 weeks ago
MCatherine1994 commented 3 weeks ago

Hi Nick, it looks good to me, but let's add a screenshot or a short video of the loading behaviour. To force loading so we can test the behaviour, you can add 5s sleep time in the api, thanks!!

image
sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

NickSaglioni commented 2 weeks ago

Hi Nick, it looks good to me, but let's add a screenshot or a short video of the loading behaviour. To force loading so we can test the behaviour, you can add 5s sleep time in the api, thanks!!

image

There is a quick movie with the loading in action:

https://github.com/bcgov/nr-forests-access-management/assets/117364634/c8d03769-bdd1-4845-ae66-19c9924c14a0