bcgov / nr-forests-access-management

Authorization solution for BC natural resource sector
Apache License 2.0
8 stars 2 forks source link

feat: #1372 terms and conditions component #1462

Closed J0taFerreira closed 1 week ago

J0taFerreira commented 1 week ago

using primevue dialog component to display the terms and conditions

refs: #1372 https://www.figma.com/design/VuQBlZZ1PmGUlEBJriyzo5/Manage-and-add-permissions?node-id=2193-158523&t=5N9YGxT96WBwdGjC-0

ianliuwk1019 commented 1 week ago
J0taFerreira commented 1 week ago
  • The buttons are too close to end of text.

    • Is the content correct? It does not seem to match the provided doc in the ticket. image

I'm gonna take another look but some styling is on the common repo

ianliuwk1019 commented 1 week ago

There is an error when clicks, happens also when login as IDIR. image

J0taFerreira commented 1 week ago

There is an error when clicks, happens also when login as IDIR. image

just fixed

ianliuwk1019 commented 1 week ago

There is an error when clicks, happens also when login as IDIR. image

Also just realized, behind the modal popup, the background screen should be grey and not clickable for all actions.

J0taFerreira commented 1 week ago

There is an error when clicks, happens also when login as IDIR. image

Also just realized, behind the modal popup, the background screen should be grey and not clickable for all actions.

already fixed

MCatherine1994 commented 1 week ago

Hi Jota, I pushed some changes, feel free to check it, especially for the state variable, the way how we use it. Also pointed out where we will call the Backend API. I'll let Ian take another review, should be good now. Thanks!

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MCatherine1994 commented 1 week ago

thanks so much Ian!!