search

bcgov / nr-forests-access-management

Authorization solution for BC natural resource sector
Apache License 2.0
8 stars 2 forks source link

feat: #1365 Add first, last name and email columns to fam user table #1472

Closed MCatherine1994 closed 3 months ago

MCatherine1994 commented 3 months ago

refs: #1365

image image

MCatherine1994 commented 3 months ago

Hi Ian, I wonder should we add some description to these columns? I saw some of the columns in the table have description, but some don't. Maybe these three are self-explainable?

ianliuwk1019 commented 3 months ago

Hi Ian, I wonder should we add some description to these columns? I saw some of the columns in the table have description, but some don't. Maybe these three are self-explainable?

Good point, I forgot about that, although they are very obvious. I think in the past the team starts adding comments as a best practice. Thanks.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud