ianliuwk1019
commented
7 hours ago All 3 delete actions tested working locally with
FAKE_LOAD_TEST_11498, but I see there's no changes in the /admin_management folder, it has aasync def get_verified_target_user, does it need to be updated as well?
Hi Craig,
For deletion from /admin_management, there is no scenarios to fix like the fixed one that requires verifying user externally, so there is no change. Thanks for testing them all as well! Good observation, I did remove one async but didn't notice others (lazy..). They were probably copy-paste initially left over there. I remove them, thanks for mentioning that!
sonarcloud[bot]
Closes: #1641
Adjust
get_verified_target_userrouter guard so that only BCeID requester needs to retrieve target user information from IDIM servic eto verify this user. This allows IDIR requester to be able to delete inactive users and BCeID requester to have appropriate error message when not able to delete inactive user.Add tests for the scenarios.