bcgov / nr-frontend-starting-app

This repository holds a simple Web app using React, to get team started with integrations, authentication and deeployments.
Apache License 2.0
3 stars 1 forks source link

Feat/adjust components #26

Closed mgaseta closed 1 year ago

mgaseta commented 1 year ago

Description

Adjusted the first batch of Carbon components to reflect the BC Gov Design System, mainly css adjusts. Ticket link: https://apps.nrs.gov.bc.ca/int/jira/browse/FSADT2-231

Type of change

How Has This Been Tested?

No new tests, the changes were only to components and visual.

Checklist

Further comments

github-actions[bot] commented 1 year ago

Current changelog

Bug Fixes

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-actions[bot] commented 1 year ago

Coverage report

Coverage after merging feat/adjust-components into main will be
30.39%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.tsx100%100%100%100%
src/components/BCHeader
   index.tsx100%100%100%100%
src/components/LoadingButton
   index.tsx40%25%25%45.45%37–38, 40, 40, 40–42, 44–45, 50–53, 60, 70
src/components/UserTable
   index.tsx86.67%100%75%90.91%51
src/layout/PublicLayout
   index.tsx100%100%100%100%
src/service
   FetchApi.ts4%0%0%7.14%10, 18–20, 20, 20, 20–21, 24, 41–42, 44, 44–45, 47, 50, 53, 9, 9
   GetExceptionResponse.ts14.29%0%0%20%4, 4–6, 9
src/views/Form
   index.tsx5.56%0%0%7.63%100, 100–102, 102, 102–104, 109, 109–111, 121–124, 126, 130–131, 136–141, 143–144, 148–152, 154–155, 159–160, 163–165, 165, 165–166, 171–172, 172, 172–173, 178, 180, 185, 189–190, 193–195, 195, 195–196, 201–202, 202, 202–203, 208, 210, 215, 219–220, 222, 222, 222, 222, 222, 222, 222, 224–225, 225, 225, 225, 225–227, 227, 227, 227–228, 231–232, 234, 234–235, 237, 240–242, 245–246, 249, 265, 265, 292, 30, 310, 32–34, 40–42, 50, 52–53, 55, 57–58, 60, 62–63, 69–72, 77, 79–80, 85, 87–91, 94–98
src/views/Home
   index.tsx71.43%100%33.33%81.82%18, 22
src/views/Table
   index.tsx50%100%0%66.67%4
github-actions[bot] commented 1 year ago

Your Pull Request code is being promoted! Please follow the link below. Main Merge Workflow