Release production build failing - Githubissues

bcgov / nr-hydrometric-rating-curve

A hydrometric rating curve describes the mathematical relationship between stage and discharge. The rating curve app allows users to upload any stage and discharge datasets, develop and optimize rating models as well as save and compare results from previous sessions.

Apache License 2.0

2 stars 0 forks source link

Release production build failing #192

Closed tobiasmllr closed 1 month ago

tobiasmllr commented 1 month ago

Hello, the release production build fails due to some expected PR number being unavailable: https://github.com/bcgov/nr-hydrometric-rating-curve/actions/runs/11328718083/job/31502688805

Steps I followed:

Updated 'main'
Test-version built successfully
Created new version v1.0.5
Automatic build of 'prod' for v1.0.5 failed

mishraomp commented 1 month ago

thanks for the issue @tobiasmllr.

@DerekRoberts for workflow_dispatch, there wont be any PR numbers,

should we change the https://github.com/bcgov-nr/action-get-pr to ignore workflow_dispatch. OR
should we change https://github.com/bcgov/quickstart-openshift-helpers/blob/main/.github/workflows/.deployer.yml to not run get pr number if tag is provided,

I prefer the 2nd option, but let you decide which one you would like, or if none of them and you want it to handle in different way.

mishraomp commented 1 month ago

fixed as part of #194 @tobiasmllr and latest release v1.1.0 went to prod