bcgov / nr-silva

NR SILVA Web Application - With React TS

Apache License 2.0

0 stars 0 forks source link

chore: react warnings and login issues #307

Closed RMCampos closed 1 month ago

RMCampos commented 1 month ago

Description

Fixed login issue (when the user is already logged in and tried to click the login button);
Fixed warnings related to react components and props;
Removed the address when clicked on the favourite cards;

Fixes Jira issue SILVA-389

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-307-backend.apps.silver.devops.gov.bc.ca/actuator/health Frontend: https://nr-silva-7-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run. Main Merge Workflow