bcgov / nr-silva

NR SILVA Web Application - With React TS
Apache License 2.0
0 stars 0 forks source link

feat: geospatial opening polygons first steps #308

Closed RMCampos closed 1 month ago

RMCampos commented 1 month ago

Description

Fixes Jira issue SILVA-236

Type of change

How Has This Been Tested?

Tested locally

Checklist

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-308-backend.apps.silver.devops.gov.bc.ca/actuator/health Frontend: https://nr-silva-8-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run. Main Merge Workflow

RMCampos commented 1 month ago

Needs https://github.com/bcgov/nr-silva/issues/309 to be fixed first, before merging this one.

webgismd commented 1 month ago

@RMCampos just a comment on this line https://github.com/bcgov/nr-silva/blob/4e01f5438971ec51187d22b7bc0ca1ffe5db9bb0/frontend/src/map-services/BcGwWfsApi.tsx#L168 it would be good to get confirmation for the business what they would like to do with the 20 layers they want added.. if we add 20 layers as WFS we will start to have performance issue potential. (support WMS calls with leaflet where appropriate will give you default styles that are approved by the data custodian, scale dependencies, better performance -- with GetMap - to display tiles, and GetFeatureInfo to display attributes) -- not endorsing this specific code but as an example -- https://gist.github.com/rclark/6908938 and https://leafletjs.com/examples/wms/wms.html