bcgov / nr-silva

NR SILVA Web Application - With React TS
Apache License 2.0
0 stars 0 forks source link

chore: add lint check to CI #320

Closed RMCampos closed 1 month ago

RMCampos commented 1 month ago

Description

Add lint job to detect possible issues.

Fixes Jira Ticket SILVA-399

Type of change

How Has This Been Tested?

This was tested locally.

Checklist

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-320-backend.apps.silver.devops.gov.bc.ca/actuator/health Frontend: https://nr-silva-20-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run. Main Merge Workflow

RMCampos commented 1 month ago

@DerekRoberts @jazzgrewal

P.S.: note that this PR just adds the lint job. The fixes (and test cases) will be addressed in future changes. P.P.S.: all changed files were changed running npm run lint:fix to make sure the command works, we can either remove them for the PR (they will not be covered with tests right now) or we can keep it as an a start point for the fixes.

DerekRoberts commented 1 month ago

@RMCampos Try this just to get through the PR? npm run lint || true