bcgov / nr-silva

NR SILVA Web Application - With React TS

Apache License 2.0

1 stars 0 forks source link

feat: hide checkbox when no spatial view #327

Closed RMCampos closed 3 months ago

RMCampos commented 3 months ago

Description

Simple change to address the Opening table behaviour accordingly to the Map View.

Fixes SILVA-424

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally. Unit tests will be added shortly.

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-327-backend.apps.silver.devops.gov.bc.ca/actuator/health Frontend: https://nr-silva-27-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run. Main Merge Workflow

RMCampos commented 3 months ago

Are the lint warnings a big deal? If not, I'll approve as-is.

hey! Thanks for pointing that out. I fixed most of them. There are still issues with "any" type, that's being addressed here https://github.com/bcgov/nr-silva/pull/328.