fix for 61/62

[mgtennant]

Description

Quick fixes for MOESITE-61 and MOESITE-62 MOESITE-63 seems to already be working as intended

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [ ] Test A
• [ ] Test B

Checklist

• [ ] I have read the CONTRIBUTING doc
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have already been accepted and merged

Further comments

[github-actions[bot]]

Frontend coverage report

Coverage after merging moesite-61-62-63 into main will be

1.21%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
app.controller.ts	0%	0%	0%	0%	1, 107–108, 11, 110, 110, 110, 110, 110, 112, 112, 115, 115, 115, 12, 136–137, 139, 139, 139, 139, 139, 141, 141, 144, 144, 144, 165–166, 168, 168, 168, 168, 168, 170, 170, 173, 173, 173, 18–19, 194–195, 197, 197, 197, 197, 197, 199, 199, 2, 202, 202, 202, 21, 21, 21, 21, 21, 223–224, 226, 226, 226, 226, 226, 228, 228, 23, 23, 231, 231, 231, 26, 26, 26, 3, 49, 5, 50, 52, 52, 52, 52, 52, 54, 54, 57, 57, 57, 6–7, 78–79, 8, 81, 81, 81, 81, 81, 83, 83, 86, 86, 86
app.module.ts	0%	100%	100%	0%	1, 10–12, 2–3, 31, 4–9
app.service.ts	0%	0%	0%	0%	1, 12–14, 14, 14–15, 15, 15–17, 2, 25, 3, 30, 34–36, 41, 5
main.ts	0%	100%	0%	0%	1, 11, 13–17, 20, 28, 3, 30, 32–33, 35, 4–8
src/account
account.filter.ts	0%	0%	0%	0%	1, 10, 10, 10–13, 2, 5, 7–9
account.guard.ts	0%	0%	0%	0%	1, 11, 5, 7–8, 8, 8–9
account.module.ts	0%	100%	100%	0%	1, 11, 2–4
src/authentication
authentication.controller.ts	0%	0%	0%	0%	1, 11, 15–16, 16–17, 20, 20, 20–21, 23, 3–4, 9
authentication.filter.ts	0%	0%	0%	0%	1, 12–13, 16–19, 19, 19–21, 21, 21–26, 3, 9
authentication.guard.ts	0%	0%	0%	0%	1, 10, 13–14, 14, 14–16, 16, 16–17, 19, 19, 19–20, 20, 20, 27, 27, 27, 27–28, 3, 32, 34, 34, 34, 34, 34, 36, 36, 36–37, 42–44, 44, 44, 46–47, 5, 55, 57–58, 65–66, 66, 66–68, 68, 68, 70–71, 79, 82–83, 87–88, 9
authentication.module.ts	0%	100%	100%	0%	1, 15, 2, 4–7
authentication.service.ts	0%	0%	0%	0%	1, 100–101, 104, 106–108, 11, 119–121, 123–127, 129, 135–140, 142, 145, 148, 148, 148, 151–155, 155, 155, 159–160, 163, 165–167, 173–174, 176, 179, 179–181, 183, 183, 183–185, 185, 185–186, 188, 2, 217, 22, 220–223, 226–227, 229, 229, 229, 23, 230, 232, 234, 24, 243–244, 246, 246, 248, 248, 248, 248–249, 25, 253, 257–259, 26, 260–262, 264, 27, 270, 273, 276, 276, 276, 279, 28, 280–283, 283, 283, 287–288, 291, 293–295, 3, 33, 4, 44, 46, 49, 49, 49, 5, 52–56, 56, 56, 60–61, 64, 66–68, 73, 8, 84, 86, 89, 89, 89, 92–96, 96, 96
src/authentication/dto
code.dto.ts	0%	100%	100%	0%	1
src/bc-registry
bc-registry.controller.ts	0%	0%	0%	0%	1, 101, 107, 109, 109, 109–110, 114, 114, 114–115, 119, 119, 119–120, 125, 127, 127, 127, 127, 127, 127–129, 13, 133, 139, 14, 143, 15, 151, 158, 17–18, 23–24, 29, 34, 36, 36, 36–37, 39, 39, 39–40, 44, 44, 44–45, 50, 52, 52, 52, 52, 52, 52–54, 56, 65, 70–71, 73, 73, 73–74, 76, 76, 76–77, 81, 81, 81–82, 87, 89, 89, 89, 89, 89, 89–91, 95
bc-registry.module.ts	0%	100%	100%	0%	1, 14, 2–7
bc-registry.service.ts	0%	0%	0%	0%	1, 1003–1004, 1007, 1009, 101, 1010–1011, 102–105, 108–112, 115–119, 12, 122–126, 130, 147, 158, 160–161, 164, 169–172, 178–179, 181–183, github-actions[bot] commented 2 years ago Backend coverage report Coverage after merging moesite-61-62-63 into main will be 26.70% Coverage Report File Stmts Branches Funcs Lines Uncovered Lines src    app.controller.ts 0% 100% 0% 0% 1, 10, 2, 5–6, 9    app.module.ts 0% 0% 100% 0% 1, 10–19, 2, 20–26, 28–29, 3, 30–31, 31, 31–32, 34, 4, 42, 42, 44, 44–45, 45, 5–7, 73, 8    app.service.ts 0% 100% 0% 0% 1, 13, 2, 5–6, 8    main.ts 0% 0% 0% 0% 1, 15–16, 18, 18, 18–19, 2, 20–21, 23, 3–4, 7–8 src/cron    cron.module.ts 0% 100% 100% 0% 1, 10–19, 2, 20–29, 3, 30–35, 4–7, 78, 8–9    cron.service.ts 0% 0% 0% 0% 1, 10, 100–106, 108, 11–12, 126, 13, 131, 133, 137–139, 14, 147, 149, 15–16, 169, 17, 173–179, 18, 180–189, 19, 193–199, 2, 20, 201–207, 209, 21, 210–215, 217–219, 22, 220–223, 225–229, 23, 230–231, 233–239, 241–246, 248–254, 256–262, 264–270, 272–278, 280–286, 288–294, 296–299, 3, 300–302, 304–310, 312–318, 320, 324–327, 329–331, 333–335, 337–339, 341–343, 345–347, 349–351, 353–355, 357–359, 361–363, 365–367, 369–371, 373–375, 377–379, 381–383, 385–387, 389, 393, 395, 4, 403–406, 416–419, 42, 44–49, 5, 50–59, 6, 64–65, 65–67, 72–75, 77, 79, 8, 81, 81, 81, 84–85, 9, 91–99 src/sites    sites.controller.ts 0% 100% 0% 0% 1, 10–11, 14–15, 19, 2, 20, 24–25, 29, 3, 30, 34–35, 39, 4, 40, 5–6    sites.module.ts 0% 100% 100% 0% 1, 13, 2–5    sites.service.ts 0% 100% 0% 0% 1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52 src/sites/dto    create-site.dto.ts 0% 100% 100% 0% 1–2, 4    site.dto.ts 0% 100% 100% 0% 1, 103, 109, 115, 121, 127, 13, 133, 139, 145, 151, 157, 163, 169, 175, 181, 187, 19, 193, 199, 205, 211, 217, 223, 229, 235, 241, 247, 25, 253, 259, 265, 3, 31, 37, 43, 49, 55, 61, 67, 7, 73, 79, 85, 91, 97    update-site.dto.ts 0% 100% 100% 0% 1, 3 src/sites/entities    site.entity.ts 0% 100% 0% 0% 1, 101, 11, 14, 16, 18, 2, 20, 22, 24, 26, 28, 30, 32, 34, 36, 38, 40, 42, 44, 46, 48, 5, 50, 52, 54, 56, 58, 60, 62, 64, 66, 68, 70, 72, 74, 76, 78, 80, 82, 84, 86, 88, 90, 92, 94, 96, 98 src/sraecass    sraecass.controller.ts 0% 100% 0% 0% 1, 10, 13–14, 18–19, 2, 23–24, 28–29, 3, 33–34, 38–39, 4–5, 9    sraecass.module.ts 0% 100% 100% 0% 1, 13, 2–5    sraecass.service.ts 0% 100% 0% 0% 1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52 src/sraecass/dto    create-sraecass.dto.ts 0% 100% 100% 0% 1–2, 4    sraecass.dto.ts 0% 100% 100% 0% 1    update-sraecass.dto.ts 0% 100% 100% 0% 1, 3 src/sraecass/entities    sraecass.entity.ts 0% 100% 0% 0% 11, 13, 15, 17, 19, 2, 21, 23, 25, 27, 30, 5, 7, 9 src/srapproa    srapproas.controller.ts 0% 100% 0% 0% 1, 10, 13–14, 18–19, 2, 23–24, 28–29, 3, 33–34, 38–39, 4–5, 9    srapproas.module.ts 0% 100% 100% 0% 1, 13, 2–5    srapproas.service.ts 0% 100% 0% 0% 1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52 src/srapproa/dto    create-srapproa.dto.ts 0% 100% 100% 0% 1–2, 4    srapproa.dto.ts 0% 100% 100% 0% 1    update-srapproa.dto.ts 0% 100% 100% 0% 1, 3 src/srapproa/entities    srapproa.entity.ts 0% 100% 0% 0% 1, 10, 12, 14, 16, 18, 21, 4, 6, 8 src/srassocs    srassocs.controller.ts 53.85% 100% 14.29% 68.42% 14, 19, 24, 29, 34, 39    srassocs.module.ts 0% 100% 100% 0% 1, 13, 2–5    srassocs.service.ts 66.67% 100% 71.43% 65.22% 31–32, 36–39, 41, 43 src/srassocs/dto    create-srassoc.dto.ts 100% 100% 100% 100%    srassoc.dto.ts 100% 100% 100% 100%    update-srassoc.dto.ts 100% 100% 100% 100% src/srassocs/entities    srassoc.entity.ts 100% 100% 100% 100% src/srdate    srdates.controller.ts 45.16% 100% 14.29% 54.17% 14, 19–24,

Backend coverage report

Coverage after merging moesite-61-62-63 into main will be

26.70%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
app.controller.ts	0%	100%	0%	0%	1, 10, 2, 5–6, 9
app.module.ts	0%	0%	100%	0%	1, 10–19, 2, 20–26, 28–29, 3, 30–31, 31, 31–32, 34, 4, 42, 42, 44, 44–45, 45, 5–7, 73, 8
app.service.ts	0%	100%	0%	0%	1, 13, 2, 5–6, 8
main.ts	0%	0%	0%	0%	1, 15–16, 18, 18, 18–19, 2, 20–21, 23, 3–4, 7–8
src/cron
cron.module.ts	0%	100%	100%	0%	1, 10–19, 2, 20–29, 3, 30–35, 4–7, 78, 8–9
cron.service.ts	0%	0%	0%	0%	1, 10, 100–106, 108, 11–12, 126, 13, 131, 133, 137–139, 14, 147, 149, 15–16, 169, 17, 173–179, 18, 180–189, 19, 193–199, 2, 20, 201–207, 209, 21, 210–215, 217–219, 22, 220–223, 225–229, 23, 230–231, 233–239, 241–246, 248–254, 256–262, 264–270, 272–278, 280–286, 288–294, 296–299, 3, 300–302, 304–310, 312–318, 320, 324–327, 329–331, 333–335, 337–339, 341–343, 345–347, 349–351, 353–355, 357–359, 361–363, 365–367, 369–371, 373–375, 377–379, 381–383, 385–387, 389, 393, 395, 4, 403–406, 416–419, 42, 44–49, 5, 50–59, 6, 64–65, 65–67, 72–75, 77, 79, 8, 81, 81, 81, 84–85, 9, 91–99
src/sites
sites.controller.ts	0%	100%	0%	0%	1, 10–11, 14–15, 19, 2, 20, 24–25, 29, 3, 30, 34–35, 39, 4, 40, 5–6
sites.module.ts	0%	100%	100%	0%	1, 13, 2–5
sites.service.ts	0%	100%	0%	0%	1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52
src/sites/dto
create-site.dto.ts	0%	100%	100%	0%	1–2, 4
site.dto.ts	0%	100%	100%	0%	1, 103, 109, 115, 121, 127, 13, 133, 139, 145, 151, 157, 163, 169, 175, 181, 187, 19, 193, 199, 205, 211, 217, 223, 229, 235, 241, 247, 25, 253, 259, 265, 3, 31, 37, 43, 49, 55, 61, 67, 7, 73, 79, 85, 91, 97
update-site.dto.ts	0%	100%	100%	0%	1, 3
src/sites/entities
site.entity.ts	0%	100%	0%	0%	1, 101, 11, 14, 16, 18, 2, 20, 22, 24, 26, 28, 30, 32, 34, 36, 38, 40, 42, 44, 46, 48, 5, 50, 52, 54, 56, 58, 60, 62, 64, 66, 68, 70, 72, 74, 76, 78, 80, 82, 84, 86, 88, 90, 92, 94, 96, 98
src/sraecass
sraecass.controller.ts	0%	100%	0%	0%	1, 10, 13–14, 18–19, 2, 23–24, 28–29, 3, 33–34, 38–39, 4–5, 9
sraecass.module.ts	0%	100%	100%	0%	1, 13, 2–5
sraecass.service.ts	0%	100%	0%	0%	1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52
src/sraecass/dto
create-sraecass.dto.ts	0%	100%	100%	0%	1–2, 4
sraecass.dto.ts	0%	100%	100%	0%	1
update-sraecass.dto.ts	0%	100%	100%	0%	1, 3
src/sraecass/entities
sraecass.entity.ts	0%	100%	0%	0%	11, 13, 15, 17, 19, 2, 21, 23, 25, 27, 30, 5, 7, 9
src/srapproa
srapproas.controller.ts	0%	100%	0%	0%	1, 10, 13–14, 18–19, 2, 23–24, 28–29, 3, 33–34, 38–39, 4–5, 9
srapproas.module.ts	0%	100%	100%	0%	1, 13, 2–5
srapproas.service.ts	0%	100%	0%	0%	1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52
src/srapproa/dto
create-srapproa.dto.ts	0%	100%	100%	0%	1–2, 4
srapproa.dto.ts	0%	100%	100%	0%	1
update-srapproa.dto.ts	0%	100%	100%	0%	1, 3
src/srapproa/entities
srapproa.entity.ts	0%	100%	0%	0%	1, 10, 12, 14, 16, 18, 21, 4, 6, 8
src/srassocs
srassocs.controller.ts	53.85%	100%	14.29%	68.42%	14, 19, 24, 29, 34, 39
srassocs.module.ts	0%	100%	100%	0%	1, 13, 2–5
srassocs.service.ts	66.67%	100%	71.43%	65.22%	31–32, 36–39, 41, 43
src/srassocs/dto
create-srassoc.dto.ts	100%	100%	100%	100%
srassoc.dto.ts	100%	100%	100%	100%
update-srassoc.dto.ts	100%	100%	100%	100%
src/srassocs/entities
srassoc.entity.ts	100%	100%	100%	100%
src/srdate
srdates.controller.ts	45.16%	100%	14.29%	54.17%	14, 19–24,