bcgov / nr-site-bc-registries

Apache License 2.0
1 stars 0 forks source link

sorting issue and title issue #76

Closed mgtennant closed 1 year ago

mgtennant commented 1 year ago

Srprofil data was being sorted by dateCompleted as opposed to dateReceived leading to the order of site profiles being incorrect sometimes. Also added logic to ensure the site profile/site disclosure statement always has a title.

github-actions[bot] commented 1 year ago

DEV deployments have completed successfully!

Backend: [https://esra-76-backend.apps.silver.devops.gov.bc.ca/]() Frontend: [https://esra-76-frontend.apps.silver.devops.gov.bc.ca/]()

github-actions[bot] commented 1 year ago

Frontend coverage report

Coverage after merging small-bugfixes into main will be
0.97%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   app.controller.ts0%0%0%0%1, 107–108, 11, 110, 110, 110, 110, 110, 112, 112, 115, 115, 115, 12, 136–137, 139, 139, 139, 139, 139, 141, 141, 144, 144, 144, 165–166, 168, 168, 168, 168, 168, 170, 170, 173, 173, 173, 18–19, 194–195, 197, 197, 197, 197, 197, 199, 199, 2, 202, 202, 202, 21, 21, 21, 21, 21, 223–224, 226, 226, 226, 226, 226, 228, 228, 23, 23, 231, 231, 231, 250–251, 251, 251, 26, 26, 26, 3, 49, 5, 50, 52, 52, 52, 52, 52, 54, 54, 57, 57, 57, 6–7, 78–79, 8, 81, 81, 81, 81, 81, 83, 83, 86, 86, 86
   app.module.ts0%100%100%0%1, 10–12, 2–3, 31, 4–9
   app.service.ts0%0%0%0%1, 12–14, 14, 14–15, 15, 15–17, 2, 25, 3, 30, 34–36, 41, 5
   main.ts0%100%0%0%1, 11, 13–17, 20, 28, 3, 30, 32–33, 35, 4–8
src/account
   account.filter.ts0%0%0%0%1, 10, 10, 10–13, 2, 5, 7–9
   account.guard.ts0%0%0%0%1, 11, 5, 7–8, 8, 8–9
   account.module.ts0%100%100%0%1, 11, 2–4
src/authentication
   authentication.controller.ts0%0%0%0%1, 11, 15–16, 16–17, 20, 20, 20–21, 23, 3–4, 9
   authentication.filter.ts0%0%0%0%1, 11–12, 15, 15, 15–19, 19, 19–21, 21, 21–27, 27–31, 31, 31–37, 4, 9
   authentication.guard.ts0%0%0%0%1, 10, 13–14, 14, 14–16, 16, 16–17, 19, 19, 19–20, 20, 20, 27, 27, 27, 27–28, 3, 32, 34, 34, 34, 34, 34, 36, 36, 36–37, 42–44, 44, 44, 46–47, 49, 5, 51, 59, 61–62, 69–70, 70, 70–72, 72, 72, 74–75, 77, 79, 87, 9, 90–91, 95–96
   authentication.module.ts0%100%100%0%1, 15, 2, 4–7
   authentication.service.ts0%0%0%0%1, 100–101, 104, 106–108, 11, 119–121, 123–127, 129, 135–140, 142, 145, 148, 148, 148, 151–155, 155, 155, 159–160, 163, 165–167, 173–174, 176, 179, 179–181, 183, 183, 183–185, 185, 185–186, 188, 197, 199, 2, 202, 204, 204, 204–205, 205, 205–207, 210, 213, 216–217, 219, 219, 219, 22, 220, 222, 224, 23, 233–234, 236, 236, 238, 238, 238, 238–239, 24, 243, 247–249, 25, 250–252, 254, 26, 260, 263, 266, 266, 266, 269, 27, 270–273, 273, 273, 277–278, 28, 281, 283–285, 3, 33, 4, 44, 46, 49, 49, 49, 5, 52–56, 56, 56, 60–61, 64, 66–68, 73, 8, 84, 86, 89, 89, 89, 92–96, 96, 96
src/authentication/dto
   code.dto.ts0%100%100%0%1
src/bc-registry
   bc-registry.controller.ts0%0%0%0%1, 101, 107, 109, 109, 109–110, 114, 114, 114–115, 119, 119, 119–120, 125, 127, 127, 127, 127, 127, 127–129, 13, 133, 139, 14, 143, 15, 151, 158, 17–18, 23–24, 29, 34, 36, 36, 36–37, 39, 39, 39–40, 44, 44, 44–45, 50, 52, 52, 52, 52, 52, 52–54, 56, 65, 70–71, 73, 73, 73–74, 76, 76, 76–77, 81, 81, 81–82, 87, 89, 89, 89, 89, 89, 89–91, 95
   bc-registry.module.ts0%100%100%0%1, 14, 2–7
   bc-registry.service.ts0%0%0%0%src
   app.controller.ts0%100%0%0%1, 10, 2, 5–6, 9
   app.module.ts0%0%100%0%1, 10–19, 2, 20–27, 29, 3, 30–32, 32, 32–33, 35, 4, 43, 43, 45, 45–46, 46, 5–7, 75, 8
   app.service.ts0%100%0%0%1, 13, 2, 5–6, 8
   main.ts0%0%0%0%1, 15–16, 18, 18, 18–19, 2, 20–21, 23, 3–4, 7–8
src/actions
   actions.controller.ts0%100%0%0%1, 12–14, 18–19, 2, 23–24, 3–4, 8–9
   actions.module.ts0%100%100%0%1, 13, 2–5
   actions.service.ts0%100%0%0%1, 12, 16–18, 2, 22, 26, 3, 30–31, 35–37, 41–44, 46, 48, 53–55, 57, 6, 9
src/actions/dto
   action.dto.ts0%100%100%0%1
   create-action.dto.ts0%100%100%0%1–2, 4
   update-action.dto.ts0%100%100%0%1, 3
src/actions/entities
   action.entity.ts0%100%0%0%1, 10, 13, 4, 6, 8
src/cron
   cron.module.ts0%100%100%0%1, 10–19, 2, 20–29, 3, 30–35, 4–7, 78, 8–9
   cron.service.ts0%0%0%0%1, 10, 100–102, 104–107, 109, 11, 112–113, 12, 120–129, 13, 130–135, 137, 14–15, 155, 159, 16, 161, 165–167, 17, 175, 177–179, 18, 180–189, 19, 190–192, 196–199, 2, 20, 200–203, 205, 207, 21, 212–219, 22, 221, 223, 228–229, 23, 230–235, 237, 239, 24, 244–249, 25, 250–251, 253, 255, 26, 260–267, 269, 27, 271, 276–279, 28, 280–283, 285, 287, 29, 292–299, 3, 30, 301, 303, 308–309, 31, 310–315, 317, 319, 32, 324–329, 33, 330–331, 333, 335, 34, 340–347, 349, 35, 351, 356–359, 36, 360–363, 365, 367, 37, 372–379, 38, 381, 383, 388–389, 39, 390–395, 397, 399, 4, 40, 404–409, 41, 410–411, 413, 415, 42, 420–427, 429, 431, 436–439, 44, 440–443, 445, 447, 452, 454, 462–465, 47, 475–478, 49, 5, 50–59, 6, 60–65, 70–71, 71, 71–72, 74, 76–77, 77, 77, 77, 77–79, 8, 80, 80, 82–84, 84–86, 9, 92, 94, 96–98, 98, 98–99
src/sites
   sites.controller.ts0%100%0%0%1, 10–11, 14–15, 19, 2, 20, 24–25, 29, 3, 30, 34–35, 39, 4, 40, 5–6
   sites.module.ts0%100%100%0%1, 13, 2–5
   sites.service.ts0%100%0%0%1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52
src/sites/dto
   create-site.dto.ts0%100%100%0%1–2, 4
   site.dto.ts0%100%100%0%1, 103, 109, 115, 121, 127, 13, 133, 139, 145, 151, 157, 163, 169, 175, 181, 187, 19, 193, 199, 205, 211, 217, 223, 229, 235, 241, 247, 25, 253, 259, 265, 3, 31, 37, 43, 49, 55, 61, 67, 7, 73, 79, 85, 91, 97
   update-site.dto.ts0%100%100%0%1, 3
src/sites/entities
   site.entity.ts0%100%0%0%1, 101, 11, 14, 16, 18, 2, 20, 22, 24, 26, 28, 30, 32, 34, 36, 38, 40, 42, 44, 46, 48, 5, 50, 52, 54, 56, 58, 60, 62, 64, 66, 68, 70, 72, 74, 76, 78, 80, 82, 84, 86, 88, 90, 92, 94, 96, 98
src/sraecass
   sraecass.controller.ts0%100%0%0%1, 10, 13–14, 18–19, 2, 23–24, 28–29, 3, 33–34, 38–39, 4–5, 9
   sraecass.module.ts0%100%100%0%1, 13, 2–5
   sraecass.service.ts0%100%0%0%1, 10, 13, 17–19, 2, 23, 27, 3, 31–32, 36–39, 4, 41, 43, 48–50, 52
src/sraecass/dto
   create-sraecass.dto.ts0%100%100%0%1–2, 4
   sraecass.dto.ts0%100%100%0%1
   update-sraecass.dto.ts0%100%100%0%1, 3
src/sraecass/entities
   sraecass.entity.ts0%100%0%0%11, 13, 15, 17,