search

bcgov / nr-site-registry

NR EPD SITE REGISTRY
Apache License 2.0
1 stars 0 forks source link

Update PR Pipeline to run UT #113

Open mishraomp opened 1 day ago

mishraomp commented 1 day ago

Currently no UTs run during PR pipeline,

Once sonar is setup, update the PR pipeline to have UT and sonar checks.

https://github.com/BCDevOps/devops-requests/issues/1734

FYI @acoard-aot

acoard-aot commented 1 day ago

Thanks Om, will do.

acoard-aot commented 20 hours ago

Handling in https://github.com/bcgov/nr-site-registry/pull/121

acoard-aot commented 20 hours ago

@mishraomp, can you please grant me sufficient permissions to configure SonarCloud?

acoard-aot commented 20 hours ago

Also mind spot checking this run? Did it run okay? https://github.com/bcgov/nr-site-registry/actions/runs/11412320501/job/31758109467?pr=121

I can't fully tell if it's working without SonarCloud setup. But I would expect to see the logs from running the test, and don't seem to see that, even though the job runs okay.

mishraomp commented 17 hours ago

@acoard-aot I see the sonar tokens added already, so I think you got that already, for the tests not running since there are no changes to backend or frontend triggers not firing