craigyu commented 1 month ago

Description

Closes #855

Resolved ~KNOWN ISSUE~: ~~The delete button in edit mode is giving off errors in console, but it's because of this: https://github.com/carbon-design-system/carbon/pull/11893 Will talk to designers about it~~

Solution: use normal tertiary icon only button but make it red

A-Class context to store the users' input data for this section, this section does not exist in the registration forms so it have to be created. the context file for a-class is becoming too large, might need to find a way to streamline it, but it works for now
The Review Seedlot button can only be seen with seedlot that aren't in "PND" or "INC" status
Refactored GET seedlot by seedlot number endpoint so it returns additional values rather than just the row in the seedlot table
CodeDescriptionDto is now a class instead of record so it can be extended by other dtos

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

RMCampos commented 1 month ago

BTW, It's so nice to see all those TS types and null comparisions. Make Javascript looks so professional 😆

craigyu commented 1 month ago

BTW, It's so nice to see all those TS types and null comparisions. Make Javascript looks so professional 😆

Thank you! without them it works still but it's easier to do dev work this way

craigyu commented 1 month ago

forgot to fix the carbon button issue from yesterday

craigyu commented 1 month ago

bcgov / nr-spar