bcgov / nr-spar

SPAR app from FDS (Forestry Digital Services)

https://www2.gov.bc.ca/gov/content/industry/forestry/managing-our-forest-resources/tree-seed/seed-planning-use/spar

Apache License 2.0

1 stars 0 forks source link

feat: 1221 spz list endpoint modification #1225

Closed craigyu closed 1 week ago

craigyu commented 3 weeks ago

Description

Closes #1221

Changelog

New

None

Changed

/api/area-of-use/tested-parent-trees/spz-list is now/api/area-of-use/spz-list/vegetation-code/{vegCode} The old SPAR lets users select any spz they want then deny them once a user submits the data if it's invalid. This modified endpoint provides users with valid options to begin with so TSC admins should can age slower.
moved /api/orchards/area-of-use/spu/{spuId} under its own Area Of Use section as/api/area-of-use/spu/{spuId} so it makes more sense

Removed

None

How was this tested?

[ ] 🧠 Not needed
[x] 👀 Eyeball
[x] 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

craigyu commented 1 week ago

thanks for the review @RMCampos, all issues should be addressed in this commit https://github.com/bcgov/nr-spar/pull/1225/commits/141103444da582adcccfe177485fb266d472fba9

Saw your suggestion in another PR, updated the description here as well https://github.com/bcgov/nr-spar/pull/1225/commits/435167792478821fa8248035211124f174f1b2f9