bcgov / nr-spar

SPAR app from FDS (Forestry Digital Services)
https://www2.gov.bc.ca/gov/content/industry/forestry/managing-our-forest-resources/tree-seed/seed-planning-use/spar
Apache License 2.0
3 stars 0 forks source link

update date rules in seedlot registration screens #1387

Closed SLDonnelly closed 2 months ago

SLDonnelly commented 3 months ago

Issue:

During testing, a user identified a validation rule that needs to be addressed: storage end date can’t start before collection end date (same dates are okay)

In addition, the TSC is concerned about allowing users to enter dates in the future. Submission of estimated/ball park dates could lead to inaccurate dates which has implications for the TSC when trying to understand poor germination or issues with seedlots (storage dates help understand if seed got damaged/moldy) during storage etc.

Acceptance criteria:

  1. storage end date can’t start before collection end date (same dates are okay).
  2. dates that occur in the future are not permitted
craigyu commented 3 months ago

@SLDonnelly What's considered as future? After user's today? (regarding to point 2)

SLDonnelly commented 3 months ago

@craigyu dates after today

craigyu commented 3 months ago
  1. dates that occur in the future are not permitted

what are the "dates" here, all date inputs?

@SLDonnelly