bcgov / nr-spar

SPAR app from FDS (Forestry Digital Services)
https://www2.gov.bc.ca/gov/content/industry/forestry/managing-our-forest-resources/tree-seed/seed-planning-use/spar
Apache License 2.0
2 stars 0 forks source link

text update found by kevin #1421

Closed craigyu closed 3 weeks ago

craigyu commented 1 month ago

Update some text listed in #1272

  1. Register an a-class seedlot:

    Image

    • [x] I would remove the subheading "Register a new A-class seedlot" (redundant with heading above)

    Originally posted by @kevinginley in #1272

  2. A-class seedlot created:

    Image

    • [x] Change "Seedlot's main screen" to:

    "Seedlots main screen"

    (removing apostrophe)

    Originally posted by @kevinginley in #1272

  3. Client search modal:

    Image

    "To view more information about the client, you can go to client search screen."

    • [x] change to:

    "To view more information about the client, go to the client search screen."

    Originally posted by @kevinginley in #1272

  4. Collection methods:

    Image

    • [ ] Would it make sense to list the collection methods in alphabetical order?

    Originally posted by @kevinginley in #1272

  5. Cone and pollen count:

    Image

    "Enter the estimative of Cone and pollen count for the orchard's seedlot (*required)"

    I would change it to:

    • [x] "Enter the cone and pollen count estimate for the orchard's seedlot"

    SMP success on parent:

    Image

    "Enter the same SMP success on parent or Non-orchard pollent contaminant to all parent trees"

    • [x] I would change "Non-orchard" to "non-orchard"

    Calculation of SMP mix:

    Image

    "Enter the estimative of SMP success for the orchard's seedlot"

    I would change to:

    • [x] "Enter the SMP success estimate for the orchard's seedlot"

    Originally posted by @kevinginley in #1272

  6. File upload:

    Image

    "Note: When uploading a file all previously filled data within the table will be replaced."

    Please change to:

    • [x] "Note: When uploading a file, all previously filled data in the table will be replaced."

    Originally posted by @kevinginley in #1272

  7. Breeding value of SMP mix used Image

    The subheading is redundant here in my opinion. I would remove that and update the heading to read:

    "Breeding value of SMP mix used on parent"

    Originally posted by @kevinginley in #1272

  8. Image

    "SMP Mix geospatial summary"

    Please change to:

    • [x] "SMP mix geospatial summary"

    Originally posted by @kevinginley in #1272

    • [ ]

      Step 6:

      Image

      "Enter the extractory agency information and extraction's star and end dates for this seedlot"

      change to:

      • [x] "Enter the extractory agency information and extraction's start and end dates for this seedlot"

      (change "star" to "start")

      Image

      "Enter the seed storage agency information and storage's star and end dates for this seedlot"

      change to:

      • [x] "Enter the seed storage agency information and storage's start and end dates for this seedlot"

      (change "star" to "start")

    Originally posted by @kevinginley in #1272

  9. Image

    • [x] Change instances of "Tree Seed Center" to instead read "Tree Seed Centre"

    This one's a bit tricky, but in Canada we use the French spelling of center, so it should actually be "Tree Seed Centre" instead of "Tree Seed Center"

    When Tree Seed Centre comes up in data queries, it is spelled the French way in the database, so it would be nice to keep consistent.

    Hopefully this is more of a find-and-replace kind of function in the front-end

    Originally posted by @kevinginley in #1272

  10. Declaration modal:

    Image

    Declaration:

    "Please, be sure to review the content and check if everything is correct with your seedlot registration.

    Go to first step and review the form."

    Please change to:

    • [x] "Please review this form to ensure the information is correct for this seedlot registration.

    Click here to go back to the first step."

    And then have "Click here" link to the first step in the form

    Originally posted by @kevinginley in #1272

ngunner15 commented 1 month ago

1.

Do we want to remove the subtitle for the favorite card too? @kevinginley Image

kevinginley commented 1 month ago

Yes, thank you!

ngunner15 commented 1 month ago

Reduced story point from 2 > 1, less complicated task.

kevinginley commented 1 month ago

@ngunner15 Looking good! A few remaining changes: Client search

Please change "go to client search screen." to: "go to the client search screen."

When I click "go to client search screen", it didn't take me anywhere. Also, I'm confused, because aren't we already on the client search screen?

Step 5:

I requested "Enter the estimative of Cone and pollen count for the orchard's seedlot (*required)"

be changed to: "Enter the cone and pollen count estimate for the orchard's seedlot"

My apologies - I didn't mean to remove "(required)". Can you please update it to read: "Enter the cone and pollen count estimate for the orchard's seedlot (required)"

Please update the heading from "Breeding value of SMP mix used" to: "Breeding value of SMP mix used on parent"

and remove the subheading "Check the breeding value of SMP mix used on parent:

Step 6 - "Click here" should link to the first step in the current form, if possible.

Thank you

kevinginley commented 1 month ago

Not sure if this is the right ticket to bring this up, but I noticed some funky text alignment issues on Step 5 when I had SPAR only take up half of my screen. image

and also the placement of the search button alignment is looking a little funny in client search: clientsearch_button-alignment

ngunner15 commented 1 month ago

@ngunner15 Looking good! A few remaining changes: Client search

Please change "go to client search screen." to: "go to the client search screen."

When I click "go to client search screen", it didn't take me anywhere. Also, I'm confused, because aren't we already on the client search screen?

Step 5:

I requested "Enter the estimative of Cone and pollen count for the orchard's seedlot (*required)"

be changed to: "Enter the cone and pollen count estimate for the orchard's seedlot"

My apologies - I didn't mean to remove "(required)". Can you please update it to read: "Enter the cone and pollen count estimate for the orchard's seedlot (required)"

Please update the heading from "Breeding value of SMP mix used" to: "Breeding value of SMP mix used on parent"

and remove the subheading "Check the breeding value of SMP mix used on parent:

Step 6 - "Click here" should link to the first step in the current form, if possible.

Thank you

Completed all changes except Step 6, I will need more time to figure out how to add a link.

ngunner15 commented 1 month ago

<ToastNotification>

I'm not able to add a link to this component

ngunner15 commented 1 month ago

@ngunner15 Looking good! A few remaining changes: Client search Please change "go to client search screen." to: "go to the client search screen." When I click "go to client search screen", it didn't take me anywhere. Also, I'm confused, because aren't we already on the client search screen? Step 5: I requested "Enter the estimative of Cone and pollen count for the orchard's seedlot (required)" be changed to: "Enter the cone and pollen count estimate for the orchard's seedlot" My apologies - I didn't mean to remove "(required)". Can you please update it to read: "Enter the cone and pollen count estimate for the orchard's seedlot (*required)" Please update the heading from "Breeding value of SMP mix used" to: "Breeding value of SMP mix used on parent" and remove the subheading "Check the breeding value of SMP mix used on parent: Step 6 - "Click here" should link to the first step in the current form, if possible. Thank you

Completed all changes except Step 6, I will need more time to figure out how to add a link.

To be completed by @mgaseta

ngunner15 commented 1 month ago

Remove description prop for Favourite Cards. Done

Image

Should I remove the subtitle for all the pages? @craigyu @SLDonnelly @mmarsoleta

Image


Image